Uploaded image for project: 'App Framework'
  1. App Framework
  2. AF-21

Support comments in app and extension json files

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Must
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
    • Complexity:
      Medium

      Description

      The json format does not technically allow comments, however this is going to lead to unmanageable code and system configurations.

      (Example: this would be much more readable if we could use comments to specify which uuids refer to which encounter types: https://github.com/PIH/openmrs-module-mirebalais/commit/913f8994ca6d1acf0aeddfb13201042ff72be452#omod/src/main/resources/apps/encounterDisplay_extension.json )

      I propose that we make a change in AppConfigurationLoaderFactory (to the ObjectMapper, I assume) to enable Jackson's ALLOW_COMMENTS feature.

        Attachments

          Activity

            People

            Assignee:
            coleman Ben Coleman
            Reporter:
            darius Darius Jazayeri
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours Time Not Required
                3h