Details
-
Type:
Bug
-
Status: Code Review (Initial)
-
Priority:
Should
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Complexity:Low
Description
To reproduce the exception:
1.Install the module, upload the basic report template available at the github repo- https://github.com/hispindia/dhisreport
2. Go to the reports link and click on the report name to edit the sql and replace it with :
select count(distinct p.person_id)
from person p
inner join obs o on o.person_id = p.person_id
where p.voided = 0 and o.voided = 0
and o.concept_id = 1425
and o.value_numeric = 4
3. Now try to Post/Preview the report from the reports link and give any simple inputs as shown in the image and try preview.
4. This results in an exception as shown below in the images attached as well.
Instead of this unhandled exception, the user should be redirected to the post/preview page with a message mentioning the sql query does not contain startOfPeriod and/or endOfPeriod
Gliffy Diagrams
Activity
Nicholas Edwards i'm temporarily unassigning you, please feel free to claim it whenever you can work on this ticket.
Sri Maurya Kummamuru
added a comment - Nicholas Edwards i'm temporarily unassigning you, please feel free to claim it whenever you can work on this ticket. Sri Maurya Kummamuru When i compile this module it throws me a build failure error, what could be the problem? http://pastebin.com/VfLYshxn
Hillary Bagiire
added a comment - - edited Sri Maurya Kummamuru When i compile this module it throws me a build failure error, what could be the problem? http://pastebin.com/VfLYshxn Looks like a permission issues. Check to confirm that the account you used to logon the computer has permissions on the module's folders and files.
Daniel Kayiwa
added a comment - Looks like a permission issues. Check to confirm that the account you used to logon the computer has permissions on the module's folders and files. Please review my pull request.
Choxmi Sathsara
added a comment - Please review my pull request. Choxmi Sathsara did you get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips
Daniel Kayiwa
added a comment - Choxmi Sathsara did you get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips Daniel Kayiwa I made the changes and resubmitted the PR. Please review and give feedback.
Choxmi Sathsara
added a comment - Daniel Kayiwa I made the changes and resubmitted the PR. Please review and give feedback. 
hello Nicholas Edwards are you still working on this issue?