Uploaded image for project: 'FHIR Module v2'
  1. FHIR Module v2
  2. FM2-268

Remove redundant interfaces

    XMLWordPrintable

Details

    • Enhancement
    • Status: Closed
    • Could
    • Resolution: Won't Fix
    • FM2 1.0.0
    • FM2 1.2.0
    • None
    • None
    • Low

    Description

      We discussed this issue in one of the weekly meetings and I am filing this based on that conversation:

      The issue:
      There are many interfaces in the FHIR module that have a single implementation and it is not obvious if in future there is a legitimate case to implement those interfaces differently. The reason for creating these seems to be for have maximum flexibility but we agreed that having one Service and one Translator interface per FHIR resource is good enough.

      The fix:
      Remove other interfaces including those for Dao objects and pieces of Translators and replace them with the single implementation they have. This should remove ~50 interfaces (based on some quick heuristic counting). For naming, I suggest that we use the "Impl" suffix only when we are implementing an interface. A sample commit is here: https://github.com/openmrs/openmrs-module-fhir2/pull/227/commits/d40cc17548915dd1050b1f5c1fab7b9f3965b782

      Gliffy Diagrams

        Attachments

          Activity

            People

              Unassigned Unassigned
              bashir Bashir Sadjad
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: