Uploaded image for project: 'Legacy UI Module'
  1. Legacy UI Module
  2. LUI-126

Avoid universal CSS (*) selector

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: 1.3.3
    • Fix Version/s: 1.3.4
    • Labels:
    • Complexity:
      Low

      Description

      * is being used in openmrs-module-legacyui/blob/master/omod/src/main/webapp/resources/css/openmrs.css

      Wildcard * in CSS can produce unexpected results, as it applies to every element on a page.

      Example:

      * { 
        color: blue
      }
      
      li { 
        color: red 
      }
      

      Here <li>text</li>, the text still will be blue!

      So in openmrs.css we can't override font-family attribute for any other element because * always take precedence. (This might not affect all browsers)

      So I recommend moving font-family: Verdana, 'Lucida Grande'.. attribute to html { } tag instead.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                Snaddyvitch Dispenser Conor Howland (Inactive)
                Reporter:
                gayanw Gayan Weerakutti
                Designated Committer:
                Conor Howland (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 3 hours
                    3h