Details
-
Bug
-
Status: Approved
-
TBD
-
Resolution: Fixed
-
None
-
None
-
Undetermined
Description
The appointment types that we included for demonstration purposes are included as part of the referencemetadata module, but they should be in the referencedemodata module. As it stands now, no implementation can remove them.
See https://talk.openmrs.org/t/why-do-deleted-appointment-module-types-return-after-restart/5655
Dev Notes
The fix here is probably as easy as just moving these two files to openmrs-module-referencedemodata:
- https://github.com/openmrs/openmrs-module-referencemetadata/blob/master/api/src/main/java/org/openmrs/module/referencemetadata/bundle/AppointmentMetadata.java
- https://github.com/openmrs/openmrs-module-referencemetadata/blob/master/api/src/main/java/org/openmrs/module/referencemetadata/handler/AppointmentTypeDeployHandler.java
...plus maybe a couple of lines like these:
- https://github.com/openmrs/openmrs-module-referencemetadata/blob/a10af58f182786794ad916364c9f6c644d924e01/api/src/main/java/org/openmrs/module/referencemetadata/ReferenceMetadataActivator.java#L116
- https://github.com/openmrs/openmrs-module-referencemetadata/blob/a10af58f182786794ad916364c9f6c644d924e01/omod/src/main/resources/config.xml#L34
- https://github.com/openmrs/openmrs-module-referencemetadata/blob/a10af58f182786794ad916364c9f6c644d924e01/api/src/test/resources/test-hibernate.cfg.xml#L16
To test this:
- run the complete reference application including the referencedemodata module, and make sure these appointment types exist.
- remove the referencedemodata module
- via the admin UI, delete one of the appointment types
- restart OpenMRS (jetty or tomcat), still without the referencedemodata module, and verify that the deleted appointment type is not added back.
Gliffy Diagrams
Attachments
Issue Links
- mentioned in
-
Page Loading...