Uploaded image for project: 'Reference Application'
  1. Reference Application
  2. RA-425

Tech Debt: move inline css in allergies code to scss

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: OpenMRS 2.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Complexity:
      Low
    • Sprint:
      Allergy Sprint 1

      Description

      To align with the style guide, we need to:

      • move the CSS that is currently defined inline in allergies pages (fragments/allergies.gsp, pages/allergies.gsp, pages/allergy.gsp) into scss files
      • only use colors that are defined (semantically) as variables in uicommons. If we are missing some necessary colors, we need to add them.

      There's already an allergy.scss, which shows the pattern. (We want one scss file per page.)

      The one piece of styling that's okay to leave inline is style="display:none"

        Gliffy Diagrams

          Attachments

            Issue Links

              Attachments-Category-Modification

                Activity

                  People

                  • Assignee:
                    burke Burke Mamlin
                    Reporter:
                    darius Darius Jazayeri
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: