Uploaded image for project: 'Reference Application'
  1. Reference Application
  2. RA-429

Reference application contains duplicate concepts for yes/true and no/false

    XMLWordPrintable

    Details

    • Complexity:
      Low

      Description

      Background

      The reference application contains a subset of concepts from the CIEL concept dictionary. In this dictionary the concepts 1065 and 1066 should correspond to TRUE and FALSE.

      However when you install the reference application you also end up with concepts 1 and 2 for TRUE and FALSE.

      This is bad.
      (To produce this error first install the platform without demo data, and then install the reference application)

      Acceptance Criteria

      1. A clean installation of should end up with one concept for TRUE (1065) and one for FALSE (1066), and no concepts with id 1 or 2.
      2. Upon upgrading an existing OpenMRS installation, if it has two TRUE or FALSE concepts, the administrator should be shown instructions about how to clean this up in their database.

      Dev notes

      This probably happens because there's a liquibase changeset in the OpenMRS install that creates those concepts if they don't exist already (see BooleanConceptChangeSet), and later the referencemetadata module loads the CIEL concepts.

      Showing a hint to the administrator could be done using this interface: org.openmrs.module.appframework.factory.AdministrativeNotificationProducer (and you can see an example of how this is used in the Atlas module)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mozzy Moses Mutesasira
              Reporter:
              akanter Andrew Kanter
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated: