Uploaded image for project: 'Webservices REST Module'
  1. Webservices REST Module
  2. RESTWS-791

Search and fix minor errors

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Non-Essential
    • Resolution: Won't Do
    • None
    • None
    • None
    • Undetermined

    Description

      This ticket includes openmrs-module-webservices.rest -> https://github.com/openmrs/openmrs-module-webservices.rest

      While reading the code and browsing the classes I come across a lot of small errors, such as:

      • unused imports
      • unused variables
      • wrong order of modifiers
      • various other bad practices

      This issue was created for the purpose of grouping tasks for people who are starting their adventure with JIRA and GitHub, and at the same time want to support the development of OpenMRS.

      Do not assign a grouping ticket to yourself.

      If you are a beginner and a subtask is free and ready to work, I invite you to assign it to yourself and solve it.

      If you have any questions about this task or any subtask, write: https://talk.openmrs.org/t/search-and-fix-minor-errors-and-typos/29416

      Gliffy Diagrams

        Attachments

          1.
          Sections of code should not be commented out Sub-task Closed Kathryn Ellington

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 1 hour
          2.
          Empty statements should be removed Sub-task Closed Kathryn Ellington

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 1 hour
          3.
          Unused assignments should be removed Sub-task Closed grace nakiguli

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 2 weeks
          4.
          Unnecessary imports should be removed Sub-task Closed Kakumirizi Daud

          50%

          Original Estimate - 2 hours
          Time Spent - 1 hour Remaining Estimate - 1 hour
          5.
          Local variables should not be declared and then immediately returned Sub-task Closed Kakumirizi Daud

          100%

          Original Estimate - 1 day Original Estimate - 1 day
          Time Spent - 1 week
          6.
          "if-else" clauses should be enclosed in curly braces Sub-task Closed Ankit kumar  
          7.
          Parameterized messages should be used for logging Sub-task Closed grace nakiguli

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 3 hours
          8.
          Overriding methods should do more than simply call the same method in the super class Sub-task Closed Kakumirizi Daud

          100%

          Original Estimate - 2 days Original Estimate - 2 days
          Time Spent - 1 week
          9.
          Assertion arguments should be passed in the correct order Sub-task Closed Kathryn Ellington

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 3 hours, 30 minutes
          10.
          Modifiers should be declared in the correct order Sub-task Closed Kakumirizi Daud

          25%

          Original Estimate - 1 day
          Time Spent - 2 hours Remaining Estimate - 6 hours
          11.
          Collapsible "if" statements should be merged Sub-task Closed lobe nyoh serge

          75%

          Original Estimate - 4 hours
          Time Spent - 3 hours Remaining Estimate - 1 hour
          12.
          Two branches in a conditional structure should not have exactly the same implementation Sub-task Closed Ankit kumar  
          13.
          Return of boolean expressions should not be wrapped into an "if-then-else" statement Sub-task Closed Pranay Chauhan  
          14.
          Constructors should not be used to instantiate "String" Sub-task Closed Ankit kumar  
          15.
          Resources should be closed Sub-task Closed Ankit kumar  
          16.
          Short-circuit logic should be used in boolean contexts Sub-task Closed Pranay Chauhan  
          17.
          Utility classes should not have public constructors Sub-task Closed Ankit kumar  
          18.
          "@Deprecated" code should not be used Sub-task Closed Unassigned  
          19.
          Boolean expressions should not be gratuitous Sub-task Closed grace nakiguli

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 1 week
          20.
          "@Override" should be used on overriding and implementing methods Sub-task Closed Pranay Chauhan  
          21.
          Collection.isEmpty() should be used to test for emptiness Sub-task Closed Pranay Chauhan  
          22.
          Strings should not be compared by using == or != Sub-task In Progress kimote Hillary

          100%

          Original Estimate - 1 hour
          Time Spent - 1 hour

          Activity

            People

              Unassigned Unassigned
              sacull Lukasz Debicki
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 4 days, 7 hours Original Estimate - 4 days, 7 hours
                  4d 7h
                  Remaining:
                  Time Spent - 5 weeks, 1 day, 7 hours, 30 minutes Remaining Estimate - 1 day
                  1d
                  Logged:
                  Time Spent - 5 weeks, 1 day, 7 hours, 30 minutes Remaining Estimate - 1 day
                  5w 1d 7h 30m