Details
-
Bug
-
Status: Closed
-
Should
-
Resolution: Fixed
-
None
-
None
-
None
Description
The sqldiff for 1.3.0.14 incorrectly converts from Manage Encounter Types to Add/Edit/Delete instead of going the other way.
This is actually a sort-of blocker for anyone who had specifically given that privilege to any role, but nobody in that situation seems to have upgraded past API-refactoring yet.
The error you'd see is that as soon as you somehow load a User who has a Role that has one of the non-existent privileges, things crash. (In my case Data Assistant has Add Encounter Types. I tried to do a "Download Concept Dictionary" and around concept 1500 I hit one whose creator was a Data Assistant, and it broke then.)
I propose fixing this in 1.4.0.18, although that means that anyone who tries to upgrade past 1.3.0.14, but not all the way to 1.4.0.18 will end up with a temporarily broken install. I think it would be wrong to edit a past sqldiff, even if it's one that apparently hasn't hit anyone yet.
Ben, can you confirm that strategy? (Patch coming in a sec.)