[TRUNK-324] Go through the TODO items code and create tickets out of them - OpenMRS Issues

XML

Word

Printable

Details

Type: Epic
Status: Ready for Work
Priority: Should
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: Feb 2012 Bug Fixing Sprint, Core 2.2.0
Component/s: None
Labels:
- curated
- intro
- non-coding

Complexity:
Low

Description

There are a good number of TODO items in the core code. They aren't doing much good in this state. These items should be examined and tickets made for them to be fixed.

Do a global search for the word "TODO" in the api and web projects
Add a ticket with as much description as possible. (file it was in, line number, and the TODO wording)
Link those tickets to this ticket.
Someone with more knowledge of the codebase can fill in more details around the ticket.

If you're feeling frisky, go ahead and create pull requests for the tickets that you've made!

Gliffy Diagrams

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

eclipse.exe
2022-08-22 20:18:40 GMT
519 kB
Jane Bukirwa
image-2019-07-29-14-33-12-385.png
2019-07-29 06:33:12 GMT
10 kB
isaac lin

Issue Links

is related to

TRUNK-4924 BaseCustomizableData setAttribute fail on minOccurs and maxOccurs

Closed

TRUNK-5307 Create test case for getFormCriteria

Closed

TRUNK-4923 Remove TODOs from code about addAttribute() needs validation

Closed

TRUNK-4925 Copy patient specific attributes on Patient() constructor

Closed

TRUNK-4926 Remove a TODO in code about PatientIdentifierType.toString() returning a more "debug-worth" string

Closed

TRUNK-4927 Remove a TODO in code about config parameter from DatatypeService.getDatatype

Closed

TRUNK-5306 Use Spring's method injection to set the dependencies for the message service

Closed

TRUNK-5308 PersonServiceTest fails at getPersonAttributeTypes

Closed

TRUNK-5309 TODO item in handle() of OpenmrsObjectSaveHandler.java

Closed

TRUNK-5310 Implement globalPropertyDeleted in AdministrationServiceImpl.java

Closed

TRUNK-5311 Take care of cascade=true in purgeObs in ObsServiceImpl.java

Closed

TRUNK-5312 Search for usage of getPatients in PatientServiceImpl w/ non-empty list of patient identifier types

Closed

TRUNK-5313 mergeVisits in PatientServiceImpl should copy not move

Closed

TRUNK-5314 mergeEncounters in PatientServiceImpl should copy not move

Closed

TRUNK-5315 mergeObservationsNotContainedInEncounters in PatientServiceImpl should copy not move

Closed

TRUNK-5316 Allow patient to exit multiple times in saveReasonForExitObs in PatientServiceImpl

Closed

TRUNK-5317 TODO item in saveReasonForExitObs() in PatientServiceImpl

Closed

TRUNK-5318 TODO item in saveCauseOfDeathObs in PatientServiceImpl

Closed

TRUNK-5319 getPatients in PatientServiceImpl - "search for usage with non-empty list of patient identifier types - not used"

Closed

TRUNK-5320 Check required fields for user in createUser in UserServiceImpl

Closed

TRUNK-5321 TODO: make gender a (definable?) constant in PersonService

Closed

TRUNK-5325 Decide whether to move saveAttributesIfNecessary into a SingleCustomValueSaveHandler

Closed

TRUNK-5565 SimpleXStreamSerializer

Closed

TRUNK-5601 org/openmrs/api/ObsServiceTest.java

Closed

TRUNK-5602 org/openmrs/logic/result/Result.java

Closed

TRUNK-5603 org/openmrs/api/PatientServiceTest.java

Closed

TRUNK-5605 org/openmrs/logic/Rule.java

Closed

TRUNK-5606 org/openmrs/api/OrderServiceTest.java

Closed

TRUNK-5607 org/openmrs/logic/Rule.java

Closed

TRUNK-5608 org/openmrs/util/databasechange/MigrateAllergiesChangeSet.java

Closed

TRUNK-5609 org/openmrs/util/databasechange/MigrateAllergiesChangeSet.java

Closed

TRUNK-5610 org/openmrs/api/EncounterServiceTest.java

Closed

TRUNK-5611 org/openmrs/api/FormServiceTest.java

Closed

TRUNK-5612 org/openmrs/OrderTest.java

Closed

TRUNK-5613 org/openmrs/util/DoubleRange.java

Closed

TRUNK-5614 org/openmrs/util/OpenmrsConstants.java

Closed

TRUNK-5615 org/openmrs/PatientTest.java

Closed

TRUNK-5616 org/openmrs/RoleTest.java

Closed

TRUNK-5617 org/openmrs/util/AttributableDate.java

Closed

TRUNK-5618 org/openmrs/ObsTest.java

Closed

TRUNK-5619 org/openmrs/util/OpenmrsUtil.java

Closed

TRUNK-5620 org/openmrs/obs/handler/ImageHandler.java

Closed

TRUNK-5621 org/openmrs/util/DatabaseUpdater.java

Closed

TRUNK-5622 org/openmrs/module/ModuleFileParser.java

Closed

TRUNK-5623 org/openmrs/obs/handler/BinaryDataHandler.java

Closed

TRUNK-5624 org/openmrs/obs/ComplexObsHandler.java

Closed

TRUNK-5625 org/openmrs/scheduler/timer/TimerSchedulerServiceImpl.java

Closed

TRUNK-5627 org/openmrs/validator/PersonNameValidator.java

Closed

TRUNK-5628 org/openmrs/validator/PersonAddressValidator.java

Closed

TRUNK-5629 org/openmrs/hl7/handler/ORUR01Handler.java

Closed

TRUNK-5630 org/openmrs/hl7/handler/ADTA28Handler.java

Closed

TRUNK-5631 org/openmrs/hl7/impl/HL7ServiceImpl.java

Closed

TRUNK-5632 org/openmrs/api/handler/OpenmrsObjectSaveHandler.java

Closed

TRUNK-5633 org/openmrs/messagesource/impl/MutableResourceBundleMessageSource.java

Closed

TRUNK-5634 org/openmrs/api/impl/UserServiceImpl.java

Closed

TRUNK-5635 org/openmrs/api/impl/AdministrationServiceImpl.java

Closed

TRUNK-5636 org/openmrs/api/impl/PatientServiceImpl.java

Closed

TRUNK-5637 org/openmrs/customdatatype/CustomDatatypeUtil.java

Closed

TRUNK-5638 org/openmrs/api/impl/ObsServiceImpl.java

Closed

TRUNK-5639 org/openmrs/api/db/hibernate/HibernatePersonDAO.java

Closed

TRUNK-5640 org/openmrs/api/context/Context.java

Closed

TRUNK-5641 org/openmrs/api/db/hibernate/HibernateFormDAO.java

Closed

TRUNK-5642 org/openmrs/api/PersonService.java

Closed

TRUNK-5643 org/openmrs/web/filter/initialization/InitializationFilter.java

Closed

TRUNK-5644 org/openmrs/web/filter/startuperror/StartupErrorFilter.java

Closed

TRUNK-5645 org/openmrs/web/filter/update/UpdateFilter.java

Closed

TRUNK-5646 org/openmrs/web/Listener.java

Closed

TRUNK-5647 org/openmrs/web/filter/initialization/wizardcomplete.vm

Closed

TRUNK-5648 liquibase-update-to-2.0.xml

Closed

TRUNK-5649 liquibase-schema-only.xml

Closed

TRUNK-5487 Add unit test to make sure all tests have a call to *assert*

Ready for Work

TRUNK-5600 org/openmrs/scheduler/SchedulerUtil.java

Needs Assessment

TRUNK-5604 org/openmrs/api/PersonServiceTest.java

Needs Assessment

TRUNK-5626 org/openmrs/obs/ComplexData.java

Needs Assessment

TRUNK-5189 Switch to Daemon user

Closed

TRUNK-4933 Create pull request to remove TODO comments from core code

Closed

TRUNK-4928 Remove code TODO about interface OpenmrsMetadata should support localized names and descriptions

Closed

TRUNK-4929 PersonName.compareTo should be controlled by a global property

Closed

TRUNK-4930 Remove a TODO in the code about AdministrationService.getPresentationLocales() return type

Closed

TRUNK-4931 Remove a TODO in code about notifying on global property name changes

Closed

TRUNK-4932 Deprecate ObsService.getComplexObs

Closed

TRUNK-4934 Make the gender parameter for getSimilarPeople() a definable constant

Closed

TRUNK-4935 Remove a TODO in code about refactoring ProgramWorkflowService.getPatientPrograms()

Closed

TRUNK-3179 Move field org.openmrs.aop.RequiredDataAdvice.fieldAccess to right place and add classname

Closed

TRUNK-3190 Create a unit test for HibernateConceptDAO.getConceptsByAnswer

Closed

TRUNK-3191 Fix method. It should probably just run updateConceptSetDerived(Concept) inside an iteration of all concept

Closed

TRUNK-3195 Create JUnit test for HibernateFormDAO.getFormCriteria's containingAnyFormField parameter

Closed

TRUNK-3196 Create JUnit test for HibernateFormDAO.getFormCriteria's containingAllFormFields parameter

Closed

TRUNK-3200 Add JUnit test for not getting voided PatientIdentifier in HibernatePatientDAO.getPatientIdentifiers

Closed

TRUNK-3201 Add JUnit test for not getting voided PatientIdentifier in method HibernatePatientDAO.getPatientIdentifiers

Closed

TRUNK-3202 Add JUnit test for getting by identifier type in method HibernatePatientDAO.getPatientIdentifiers

Closed

TRUNK-3204 Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers

Closed

TRUNK-3206 Test method HibernatePatientDAO.getPatientIdentifierTypes

Closed

TRUNK-3207 Put in orders that don't belong to any encounter in method HibernatePatientSetDAO.exportXml

Closed

TRUNK-3208 Fix leaving out patients who are voided in HibernatePatientSetDAO.getPatientsByProgramAndState

Closed

TRUNK-3209 Do not return voided patients in HibernatePatientSetDAO.getPatientsInProgram

Closed

TRUNK-3210 Do not return voided patients in HibernatePatientSetDAO.getPatientsHavingDateObs

Closed

TRUNK-3227 Get rid of the potentially-expensive call to getAllPatients()

Closed

TRUNK-3253 Add junit test for searching on voided patients

Closed

TRUNK-3255 Add a junit test for patientIdentifierType restrictions in PatientSearchCriteria.addIdentifierCriterias

Closed

TRUNK-3256 Change search by name and return the matched name instead of the primary name

Closed

TRUNK-3257 Add junit test for searching on voided patient names

Closed

TRUNK-3258 Add voidNote() method to NoteDAO

Closed

TRUNK-3260 Do not allow an empty retireReason for BaseRetireHandler

Closed

TRUNK-3263 Move the whole pattern for updateConceptIndexes into the scheduler

Closed

TRUNK-3264 Sort the preferred CustomDatatypeHandler to the top

Closed

TRUNK-3289 Delete other order stuff before deleting current order

Closed

TRUNK-3181 Make the call of public static void setUserContext(UserContext ctx); method in class org.openmrs.api.context.Context thread-safe

Closed

TRUNK-3182 Use Spring's method injection to set the dependencies for the message service

Closed

TRUNK-3254 Add junit test for searching on voided identifiers in PatientSearchCriteria.addIdentifierCriterias

Closed

TRUNK-3261 Make Global Property parsed and cached (not fetching and parsing every time)

Closed

TRUNK-3267 Delete any related objects here before deleting the obs

Closed

TRUNK-3175 Fill javadoc for class org.openmrs.activelist.ActiveListItem

Closed

TRUNK-3176 Fill javadoc for class org.openmrs.activelist.ActiveListType

Closed

TRUNK-3177 Fill javadoc for class org.openmrs.activelist.Allergy

Closed

TRUNK-3178 Fill javadoc for class org.openmrs.activelist.Problem

Closed

TRUNK-3186 Throw an Exception instead of returning null in Context

Closed

TRUNK-3205 Add Unit test for HibernatePatientDAO.getAllPatientIdentifierTypes(boolean)

Closed

TRUNK-3266 Check whether "tag.getName() == null" is automatically handled by SaveHandler for OpenmrsMetadata

Closed

TRUNK-4651 CLONE - Fill javadoc for class org.openmrs.activelist.Problem

Closed

TRUNK-3180 Put an optional expire date on items in field org.openmrs.api.context.Context.volatileUserData

Closed

TRUNK-3183 Investigate the checkCoreDataset() method; be one of the first things executed at startup?

Closed

TRUNK-3184 Refactor method public static Object getVolatileUserData(String key) in class org.openmrs.api.context.Context

Closed

TRUNK-3185 Refactor method public static void setVolatileUserData(String key, Object value) in class org.openmrs.api.context.Context

Closed

TRUNK-3188 Define why spring is demanding that this be hl7Service:setHl7Service and not hL7Service:setHL7Service

Closed

TRUNK-3192 Fix patient name searching algorithm

Closed

TRUNK-3193 Fix concept

Closed

TRUNK-3194 Make concept word search constants into settings

Closed

TRUNK-3197 Add an option for each sort Obs on each column in asc/desc

Closed

TRUNK-3198 Implement OrderType.retired

Closed

TRUNK-3199 Replace saveOrUpdate with merge

Closed

TRUNK-3211 Define whether to use effectiveDate and what if deathDate is null

Closed

TRUNK-3212 Finish getObservations() method's implementation

Closed

TRUNK-3213 Find an appropriate central place for public static List<String> findObsValueColumnName(Concept c) method

Closed

TRUNK-3214 Fix missing check for voided==false in method public Map<Integer, Object> getPatientAttributes(Cohort patients, String className, String property, boolean returnAll)