Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-3474

Remove not null constraint on the description column/property for all OpenmrsMetadata objects

    XMLWordPrintable

    Details

    • Complexity:
      Low
    • Sprint:
      OpenMRS Platform 1.11 Sprint 1

      Description

      I've often noticed validation errors when creating metadata of various types that "description" cannot be null.

      See thread here: https://groups.google.com/a/openmrs.org/d/topic/dev/n_N_VaH7vGY/discussion

      Tasks:

      • Find all Subclasses of OpenmrsMetadata, make sure that all their associated database tables don't have a not null constraint on the description column, if any does, drop it except for ConceptDescription
      • Add a not null constraint on concept_desctiption.description column if it doesn't exist
      • Go through their respective Validators, the naming convention for validators is MyObjectValidator e.g for Concept it is ConceptValidator, you also check their respective form validators for controllers e.g for Concept it would be ConceptFormValidator, make sure they dont reject null/empty descriptions.
      • Make sure all unit tests pass, if not fix failing ones.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                jbuczynski Jakub BuczyƄski
                Reporter:
                mseaton Mike Seaton
                Votes:
                1 Vote for this issue
                Watchers:
                13 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 4 hours Original Estimate - 4 hours
                    4h
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 1 day, 7 hours
                    1d 7h