Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-3849

Move Address and Name layout support classes from web layer to api layer

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Could
    • Resolution: Fixed
    • Affects Version/s: OpenMRS 1.9.3
    • Fix Version/s: Platform 2.0.0
    • Component/s: None
    • Labels:
    • Complexity:
      Low

      Description

      Proposal from Darius:

      Looking at the way code is set up now, I see (in openmrs/web):

      o.o.layout.web.LayoutSupport
      o.o.layout.web.LayoutTemplate
      o.o.layout.web.address.AddressSupport
      o.o.layout.web.address.AddressTemplate
      o.o.layout.web.name.NameSupport
      o.o.layout.web.name.NameTemplate

      I propose that we deprecate these 6 classes, and make new copies of them where they belong, in the api layer, in an org.openmrs.layout package. While we're doing that, we can do some minor cleanup to expose them as beans rather than the current hacky non-spring singleton pattern that's there now.

      This should not break any existing code for anyone. (The underlying data is in global properties, and it's fine to have two different objects both reading from one GP and listening for updates on it.) But it will allow us to fix this going forwards.

      And I believe this is completely safe to backport to 1.9.

        Attachments

          Activity

            People

            Assignee:
            kristopherschmidt Kristopher Schmidt
            Reporter:
            mogoodrich Mark Goodrich
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 hours Original Estimate - 2 hours
                2h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 30 minutes
                1d 2h 30m