Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-4613

Eliminate critical issues reported by Sonar

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Non-Essential
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Platform 2.0.0
    • Component/s: None
    • Labels:
    • Complexity:
      Medium

      Description

      Sonar https://ci.openmrs.org/sonar/drilldown/issues/1865?severity=CRITICAL reports a number of critical issues. We need to get this number down to 0 to have a green project in Sonar.

      This issue will gather all critical issues in Sonar resolved over time. We will be linking Sonar rule issues to this one. Please feel free to create any missing issues for broken Sonar rules and link them here.

        Attachments

          Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4611 Multithreaded correctness - Incorrect lazy initialization of static field

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4612 Correctness - Call to equals() comparing different types

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4614 Multithreaded correctness - Call to static DateFormat

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4615 Bad practice - Method may fail to close database resource

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4632 Dodgy - Redundant nullcheck of value known to be non-null

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4633 Correctness - Invocation of toString on an array

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed
          is depended on by

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4650 Multithreaded correctness - Static DateFormat

          • Could - Issue to be addressed as resources permit.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4652 Correctness - Method call passes null for nonnull parameter

          • Could - Issue to be addressed as resources permit.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4672 Correctness - int value cast to float and then passed to Math.round

          • Could - Issue to be addressed as resources permit.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4634 Dodgy - Write to static field from instance method

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4639 "equals(Object obj)" should be overridden along with the "compareTo(T obj)" method

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4640 Throwable.printStackTrace(...) should never be called

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4643 Performance - Method concatenates strings using + in a loop

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4644 Correctness - Possible null pointer dereference

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4645 Thread.run() and Runnable.run() should not be called directly

          • Non-Essential - Cosmetic or trivial issue generally assigned to a milestone only when someone has volunteered to address the issue.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4653 Dodgy - Dead store to local variable

          • TBD - To Be Determined. Prioritization is not yet established.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4654 Performance - Method invokes inefficient Number constructor; use static valueOf instead

          • TBD - To Be Determined. Prioritization is not yet established.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4656 Correctness - Possible null pointer dereference

          • TBD - To Be Determined. Prioritization is not yet established.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TRUNK-4657 Method may fail to clean up stream or resource on checked exception

          • TBD - To Be Determined. Prioritization is not yet established.
          • Closed

            Activity

              People

              • Assignee:
                raff Rafal Korytkowski
                Reporter:
                raff Rafal Korytkowski
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: