Details
-
Bug
-
Status: Closed
-
Non-Essential
-
Resolution: Fixed
-
None
-
None
-
Medium
Description
Sonar https://ci.openmrs.org/sonar/drilldown/issues/1865?severity=CRITICAL reports a number of critical issues. We need to get this number down to 0 to have a green project in Sonar.
This issue will gather all critical issues in Sonar resolved over time. We will be linking Sonar rule issues to this one. Please feel free to create any missing issues for broken Sonar rules and link them here.
Gliffy Diagrams
Attachments
Issue Links
- depends on
-
TRUNK-4611 Multithreaded correctness - Incorrect lazy initialization of static field
-
- Closed
-
-
TRUNK-4612 Correctness - Call to equals() comparing different types
-
- Closed
-
-
TRUNK-4614 Multithreaded correctness - Call to static DateFormat
-
- Closed
-
-
TRUNK-4615 Bad practice - Method may fail to close database resource
-
- Closed
-
-
TRUNK-4632 Dodgy - Redundant nullcheck of value known to be non-null
-
- Closed
-
-
TRUNK-4633 Correctness - Invocation of toString on an array
-
- Closed
-
- is depended on by
-
TRUNK-4650 Multithreaded correctness - Static DateFormat
-
- Closed
-
-
TRUNK-4652 Correctness - Method call passes null for nonnull parameter
-
- Closed
-
-
TRUNK-4672 Correctness - int value cast to float and then passed to Math.round
-
- Closed
-
-
TRUNK-4634 Dodgy - Write to static field from instance method
-
- Closed
-
-
TRUNK-4639 "equals(Object obj)" should be overridden along with the "compareTo(T obj)" method
-
- Closed
-
-
TRUNK-4640 Throwable.printStackTrace(...) should never be called
-
- Closed
-
-
TRUNK-4643 Performance - Method concatenates strings using + in a loop
-
- Closed
-
-
TRUNK-4644 Correctness - Possible null pointer dereference
-
- Closed
-
-
TRUNK-4645 Thread.run() and Runnable.run() should not be called directly
-
- Closed
-
-
TRUNK-4653 Dodgy - Dead store to local variable
-
- Closed
-
-
TRUNK-4654 Performance - Method invokes inefficient Number constructor; use static valueOf instead
-
- Closed
-
-
TRUNK-4656 Correctness - Possible null pointer dereference
-
- Closed
-
-
TRUNK-4657 Method may fail to clean up stream or resource on checked exception
-
- Closed
-