Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-4691

Concept and ConceptService.saveConcept should automatically set the value of "is_set"

    Details

    • Complexity:
      Low

      Description

      There is an explicit boolean field: concept.is_set.

      However it's very easy to write code where you add set members to a concept, but forget to set this field. (E.g. this example I wrote in a PIH module.)

      Dev Notes

      I suggest implementing this as a one-liner in ConceptServiceImpl.saveConcept

      Acceptance Criteria

      1. If you save a concept with isSet() == false, but setMembers().size() > 0, then isSet() should be made equal to true
      2. If you save a concept with isSet() == true, but setMembers().size() == 0, then that should be allowed

        Gliffy Diagrams

          Attachments

            Attachments-Category-Modification

              Activity

                People

                • Assignee:
                  michaelh Michael Hofer
                  Reporter:
                  darius Darius Jazayeri
                  Watchers:
                  Andrew Kanter, Burke Mamlin, Daniel Kayiwa, Darius Jazayeri, Michael Hofer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: