Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-4692

Performance improvement in LocationService getLocationsHavingAllTags

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: Platform 1.10.0, Platform 1.11.0, Platform 1.12.0
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Medium

      Description

      On Bahmni, we limit the number of locations that a user can login by using a Location Tag called "Login Location". We use Locationservice.getLocationsHavingAllTags to retrieve this. It takes quite a long time even when the result size is small.

      The reason for this is that the service retrieves all Locations to memory and checks whether the location tags are correct. If we move this to the DAO layer and do the location filtering by tags in hql, performance will improve drastically.

        Gliffy Diagrams

          Attachments

            Attachments-Category-Modification

              Activity

                People

                • Assignee:
                  vikash Vikash Gupta
                  Reporter:
                  vikash Vikash Gupta
                  Watchers:
                  Daniel Kayiwa, Darius Jazayeri, Mark Goodrich, Vikash Gupta
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 4 hours
                    4h
                    Remaining:
                    Remaining Estimate - 4 hours
                    4h
                    Logged:
                    Time Spent - Not Specified
                    Not Specified