Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-4866

Need change specification and implementation at ModuleUtil#matchRequiredVersions

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Should
    • Resolution: Won't Fix
    • None
    • None
    • None
    • Low

    Description

      In the ModuleUtil#matchRequiredVersions, it states that "return false when single entry required version beyond openmrs version" and will return true when single entry required version below openmrs version.

      For example:
      It will return false, if version = 2.1.0 and versionRange = 3.8.0. (version < versionRange)
      It will return true, if version = 2.1.0 and versionRange = 1.8.0. (version > versionRange)

      I suggest to change the specification and implementation to "return false when single entry required version beyond or below openmrs version". The reason is that: when module states the single entry openmrs version, it means openmrs should meet the exactly version as it is. Versions below or above do not satisfy the requirement. Current implementation causes system crash when loading module such that version > versionRange.

      Note: develop still can use the format [1.0.0 - 2.1.*] to specify a version range.

      Gliffy Diagrams

        Attachments

          Activity

            People

              grace Grace Potma
              ldf92 Dengfeng Li
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 hour
                  1h
                  Remaining:
                  Remaining Estimate - 1 hour
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified