Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-4957

Code cleanup: remove duplication in getApplicationDataDirectory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Core 2.1.0
    • Component/s: None
    • Complexity:
      Low

      Description

      OpenmrsUtil.getApplicationDataDirectory()

      has a duplicated branch that will never be reached:

      see

      https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/util/OpenmrsUtil.java#L1055-L1069

      I suggest removing it.

      Also we could use StringUtils.isNotBlank on the checks of the strings systemProperty and runtimeProperty

        Gliffy Diagrams

          Attachments

            Attachments-Category-Modification

              Activity

                People

                • Assignee:
                  raff Rafal Korytkowski
                  Reporter:
                  teleivo Ivo Ulrich
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 6 hours
                    6h