Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-5033

Public static fields should be final

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Core 2.2.0
    • Component/s: None
    • Labels:
    • Complexity:
      Low

      Description

      Classes OpenmrsConstants, SchedulerConstants and Security

      contain public static fields which are non-final, this makes it possible for other parts of the code to set these fields to null or any other value which could do harm.

      see sonar qube
      https://sonar.openmrs.org/project/issues?resolved=false&rules=squid%3AS1444&id=org.openmrs%3Aopenmrs

       

        Attachments

          Activity

            People

            Assignee:
            ryan84 Christopher Reynolds
            Reporter:
            teleivo Ivo Ulrich
            Designated Committer:
            Adam Barnett [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 6 hours
                2d 6h