Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-5056

Use apache StringUtils in OrderSetServiceImpl

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: TBD
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Core 2.1.0
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Low

      Description

      Replace org.springframework.util.StringUtils.hasLength used in

      https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/OrderSetServiceImpl.java#L48

      with the apache commons StringUtils.isBlank to increase readability since here we want to check if the reason is empty or null. Also we use apache commons StringUtils almost every where else.

      I just read that this is against the convention here
      https://wiki.openmrs.org/display/docs/Coding+Conventions#CodingConventions-UseofStringUtils

      so unsure if this should be done

        Attachments

          Activity

            People

            Assignee:
            getshravan shravan ramamuthy
            Reporter:
            teleivo Ivo Ulrich
            Designated Committer:
            shravan ramamuthy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours
                4h