Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-5122

Remove use of @Verifies and @verifies

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: TBD
    • Resolution: Fixed
    • Affects Version/s: Core 2.2.0
    • Fix Version/s: Core 2.2.0
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Low

      Description

      Going forward we are discouraging new contributions from using the old styles for the following reasons:

      • it violates Test Driven Development since the plugin forces you to write the should annotation sentence (of what you want to test) in an existing interface or a concrete class and not the test class. This means you have to write code before writing a test. Writing tests first naturally leads to code that is easy to test.
      • the plugin is not maintained and was not always working (URL needed to install it was broken, might not work on all IDE versions/types). This style is repeating the same sentence in 3 places (AT should on interface or class, AT verifies in javadoc, method name in the test class) in slightly different styles which without the plugin is a waste of precious time. We do want developers to contribute their time and solve problems and not get carpal tunnel syndrome (wink)
      • the OpenMRS core on Github and also modules are integrated with the continuous integration provider Travis CI so that whenever a new contribution of code comes in as a pull request the tests are run and a test coverage report is sent back to Github (via coveralls.io). So we know if your contribution is well tested

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              teleivo Ivo Ulrich
              Reporter:
              teleivo Ivo Ulrich
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: