Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-5325

Decide whether to move saveAttributesIfNecessary into a SingleCustomValueSaveHandler

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • TBD
    • Resolution: Won't Fix
    • None
    • None
    • None
    • Undetermined

    Description

      TODO item from line 226 of CustomDatatypeUtil.java in org.openmrs.customdatatype:

      /**
  * To be called by service save methods for customizable implementations.
  * Iterates over all attributes and calls save on the {@link ConceptDatatype} for any dirty ones.
  *
  * @param customizable
  */
 public static void saveAttributesIfNecessary(Customizable<?> customizable) {
  // TODO decide whether we can move this into a SingleCustomValueSaveHandler instead of leaving it here to be called by each Customizable service's save method
  for (Attribute attr : customizable.getAttributes()) {
   saveIfDirty(attr);
  }
 }

      Gliffy Diagrams

        Attachments

          Issue Links

            relates to

            Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. TRUNK-324 Go through the TODO items code and create tickets out of them

            • Should - Issue should be completed for its milestone; however, will not delay the milestone.
            • Code Review (Initial)

            Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. TRUNK-6087 COPY: Go through the TODO items code and create tickets out of them

            • Should - Issue should be completed for its milestone; however, will not delay the milestone.
            • Needs Assessment

            Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. TRUNK-6108 COPY: Go through the TODO items code and create tickets out of them

            • Should - Issue should be completed for its milestone; however, will not delay the milestone.
            • Needs Assessment

            Activity

              People

                Unassigned Unassigned
                sherlocktech Sean Stamm
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: