Details
-
Bug
-
Status: Closed
-
Should
-
Resolution: Won't Fix
-
None
-
None
-
None
-
Medium
-
Description
Break the following tasks into subtasks or other tickets that are ready for work:
1. Make these methods behave like typical Java Collection of membership (excluding voided memberships):
- contains(Integer patientId) - true if any non-voided membership for patient
- size() - total number of non-voided memberships
- isEmpty() - true if size() == 0
2. Refactor getMemberships() to exclude voided memberships.
3. Add methods for interacting with active memberships directly at Cohort level:
- hasActiveMembership(Integer patientId) - true if has active membership for patient
- activeMembershipSize() - number of active memberships
- hasNoActiveMemberships() - true if activeMembershipSize() == 0
4. Implement CohortMembership.equals() to return true if patient, start, end end dates match
Will not be covered by this ticket:
- Is "voided" really necessary for CohortMemberships?
- Unclear what the union, intersect and subtract utility method should do; ie, do they take the dates into account? (I believe right now they don't.)
Gliffy Diagrams
Attachments
Issue Links
- is related to
-
TRUNK-5380 Cohort Membership: Performance Issues
-
- Closed
-
-
TRUNK-5331 CohortMembership should not require a startDate
-
- Ready for Work
-
- relates to
-
TRUNK-5211 Cohort membership should allow null start date, and should default to this
-
- Closed
-
-
TRUNK-5375 New Core 2.1 Cohort module significantly slows down Cohort manipulation
-
- Closed
-
1.
|
Java Collections functionality of memberships |
|
Closed | Fred Rue |
2.
|
Exclusion of voided Memberships |
|
Closed | Unassigned |
3.
|
Adaption of equals for CohortMembership |
|
Closed | Fred Rue |
4.
|
Method extension for interactions at Cohort level |
|
Closed | Fred Rue |
5.
|
Fixing TRUNK-5452 - Adapt equal signature and implement hashCode |
|
Closed | Fred Rue |