Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-5845

Search and fix minor errors and typos

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Could
    • Resolution: Won't Fix
    • None
    • None
    • None
    • Undetermined

    Description

      While reading the code and browsing the classes I come across a lot of small errors and typos, such as:

      • a typo with the variable name in javadoc;
      • the singular in the name when the variable is in the plural;
      • no checking of variable type before casting from Object to another type, which may cause unsupported exceptions.

      There are certainly more errors and typos, but I have found it until now.

      This issue will be the base for sub-tasks where these errors and typos will be corrected.

      Please do not assign this task to yourself if no one is assigned to it.

      If the subtask is not assigned and you feel like doing it, go ahead.

      If you have any questions and don't want to ask them here:
      https://talk.openmrs.org/t/search-and-fix-minor-errors-and-typos/29416

      Gliffy Diagrams

        Attachments

          1.
          		 Checking the variable type before casting Sub-task Code Review (Initial) Njidda Salifu

          100%
          Original Estimate - 4 hours Original Estimate - 4 hours
          Time Spent - 6 hours
          2.
          		 Javadoc improvement Sub-task Closed Lukasz Debicki  
          3.
          		 Remove raw use of parameterized class Sub-task Closed Bartłomiej Rasztabiga  
          4.
          		 Delete unnecessary "todo" Sub-task Closed Lukasz Debicki  
          5.
          		 Simplify the code of the OpenmrsUtil class Sub-task Closed Bartłomiej Rasztabiga  
          6.
          		 Simplify the Reflect class code Sub-task Closed Bartłomiej Rasztabiga  
          7.
          		 Removing unneeded keywords from the interfaces Sub-task Closed Unassigned  
          8.
          		 Replacing Integer with int in the "for" loop in the UpdateFileParser class Sub-task Closed Lukasz Debicki  
          9.
          		 Simplify the ChangeLogDetective code Sub-task Closed Lukasz Debicki  
          10.
          		 Simplification of the ChangeLogVersionFinder class code Sub-task Closed Bartłomiej Rasztabiga  
          11.
          		 Change of object type to primitive in the NameTemplate class Sub-task Closed Lukasz Debicki  
          12.
          		 Change of object type to primitive in class HL7ServiceImpl Sub-task Closed Lukasz Debicki  
          13.
          		 Simplify the DiagnosisServiceImpl class code Sub-task Closed Bartłomiej Rasztabiga  
          14.
          		 Change of object type to primitive in class FilterUtil Sub-task Closed Lukasz Debicki  
          15.
          		 Use isEmpty() to check whether the collection is empty or not Sub-task Closed Christopher Miiro  
          16.
          		 Case insensitive string comparisons should be made without intermediate upper or lower casing Sub-task Closed Lukasz Debicki  
          17.
          		 Return of boolean expressions should not be wrapped into an "if-then-else" statement Sub-task Closed Lukasz Debicki  
          18.
          		 Collapsible "if" statements should be merged Sub-task Closed Lukasz Debicki  
          19.
          		 Utility classes should not have public constructors Sub-task Closed Lukasz Debicki  
          20.
          		 Constant names should comply with a naming convention Sub-task Closed grace nakiguli

          100%
          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 2 hours
          21.
          		 Local variable name should comply with a naming convention Sub-task Closed Lukasz Debicki  
          22.
          		 Empty statements should be removed Sub-task Closed Lukasz Debicki  
          23.
          		 Unused local variables should be removed Sub-task Closed Lukasz Debicki  
          24.
          		 Bad practice - Comparison of String objects using == or != Sub-task Closed Christopher Miiro  
          25.
          		 Lamdbas containing only one statement should not nest this statement in a block Sub-task Closed Christopher Miiro  
          26.
          		 Control structures should use curly braces Sub-task Closed Christopher Miiro  
          27.
          		 Exception classes should be immutable Sub-task In Progress Regan Joshua Makanga

          87%
          Original Estimate - 2 hours Original Estimate - 2 hours
          Time Spent - 2 hours Remaining Estimate - 17 minutes
          28.
          		 Modifiers should be declared in the correct order Sub-task Closed Ivan Nsookwa  
          29.
          		 Boolean literals should not be redundant Sub-task Closed Ivan Nsookwa  
          30.
          		 Local variables should not be declared and then immediately returned Sub-task Closed Lukasz Debicki  
          31.
          		 Overriding methods should do more than simply call the same method in the super class Sub-task Closed Lukasz Debicki  
          32.
          		 Useless imports should be removed Sub-task Closed Ivan Nsookwa  

          Activity

            People

              sacull Lukasz Debicki
              sacull Lukasz Debicki
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 6 hours Original Estimate - 6 hours
                  6h
                  Remaining:
                  Time Spent - 1 day, 2 hours Remaining Estimate - 17 minutes
                  17m
                  Logged:
                  Time Spent - 1 day, 2 hours Remaining Estimate - 17 minutes
                  1d 2h