XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Could
    • Resolution: Change Request Cancelled
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Undetermined

      Description

      Case:
      Most interfaces have "public" access modifiers that are not needed because all methods are public on the interfaces. In some interfaces, this problem does not occur.

      Consequences:
      None, because the compiler skips unnecessary access modifiers.

      Why is this worth changing?
      For readability of the source code.

      An example of an interface without modifier:
      https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/customdatatype/SingleCustomValue.java#L48

      An example of an interface with a modifier:
      https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/module/ModuleActivator.java#L27

        Gliffy Diagrams

          Attachments

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              sacull Lukasz Debicki
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: