Details
-
Sub-task
-
Status: Closed
-
Could
-
Resolution: Fixed
-
None
-
None
-
Low
Description
Following the SonarQube:
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.
First case:
- GitHub: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/context/Daemon.java
- Sonar: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=96ce4465-ee45-4137-9934-7b914b74fe49&open=96ce4465-ee45-4137-9934-7b914b74fe49
Second case:
- GitHub: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/springframework/core/JdkVersion.java
- Sonar: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDdt5zdzQEOFIPDi&open=AXParDdt5zdzQEOFIPDi
Solution:
In all cases, add a private parameterless constructor.