Details
-
Sub-task
-
Status: Closed
-
Could
-
Resolution: Fixed
-
None
-
None
-
Low
Description
From https://wiki.openmrs.org/display/docs/Java+Conventions
Modifiers should follow the order suggested by the Java Language specification, sections 8.1.1, 8.3.1, 8.4.3 and 9.4:
- public
- protected
- private
- abstract
- default
- static
- final
- transient
- volatile
- synchronized
- native
- strictfp
First case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AWmnP-z2fzIJ_whOGpFX&open=AWmnP-z2fzIJ_whOGpFX
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/context/Context.java#L188
Second case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDor5zdzQEOFIPEZ&open=AXParDor5zdzQEOFIPEZ
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/util/MemoryAppender.java#L47
Problem:
Wrong order of modifiers.
Solution:
Put the modifiers in the correct order.