Details
-
Sub-task
-
Status: Closed
-
Could
-
Resolution: Fixed
-
None
-
None
-
Low
Description
From SonarQube:
Redundant Boolean literals should be removed from expressions to improve readability.
From me:
Which one looks better?
if (booleanSomething == true) {}
or
if (booleanSomething) {}
Personally, I think SonarQube is right. The second is nicer.
First case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJ24cGYr-AYGNaF8&open=AXK-qJ24cGYr-AYGNaF8
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/db/hibernate/HibernateOrderDAO.java#L207
Second case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJ24cGYr-AYGNaF9&open=AXK-qJ24cGYr-AYGNaF9
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/db/hibernate/HibernateOrderDAO.java#L218
Third case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJ24cGYr-AYGNaF-&open=AXK-qJ24cGYr-AYGNaF-
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/db/hibernate/HibernateOrderDAO.java#L233
Problem:
Redundant use of boolean.
Solution:
Remove redundancy.