Details
-
Sub-task
-
Status: Closed
-
Could
-
Resolution: Fixed
-
None
-
None
-
Low
Description
From SonarQube:
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading. The only time this is justified is in final overriding methods, where the effect is to lock in the parent class behavior. This rule ignores such overrides of equals, hashCode and toString.
Class BaseChangeableOpenmrsData:
SonarQube links:
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=16f1068f-20f5-40e9-8e19-7956f81b5e71&open=16f1068f-20f5-40e9-8e19-7956f81b5e71
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=1338e8c1-bafd-48cd-a614-ee0e5d88c89f&open=1338e8c1-bafd-48cd-a614-ee0e5d88c89f
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=c2d36697-1fec-4279-a64f-e5a6ec9896eb&open=c2d36697-1fec-4279-a64f-e5a6ec9896eb
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=94228113-bf64-4fe1-bb7a-89962f79027d&open=94228113-bf64-4fe1-bb7a-89962f79027d
GitHub link:
Class BaseChangeableOpenmrsMetadata:
SonarQube links:
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=fbc50422-97d5-4ddb-8383-810391a03305&open=fbc50422-97d5-4ddb-8383-810391a03305
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=58bb5445-9ee2-4a42-90ba-94646a4333dd&open=58bb5445-9ee2-4a42-90ba-94646a4333dd
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=539bdd66-662c-416d-9e8e-8f41919b2620&open=539bdd66-662c-416d-9e8e-8f41919b2620
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=9f3c8351-e424-4254-b431-820525a984c2&open=9f3c8351-e424-4254-b431-820525a984c2
GitHub link:
Class ConceptSource:
SonarQube links:
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=b6a3301e-fcad-4ff0-b6ad-3b2055c54961&open=b6a3301e-fcad-4ff0-b6ad-3b2055c54961
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=dd02e03f-59d2-4958-aa95-ca35a3a5ca2b&open=dd02e03f-59d2-4958-aa95-ca35a3a5ca2b
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=c5329d70-f413-46b3-9729-148518551acc&open=c5329d70-f413-46b3-9729-148518551acc
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=dac9dc42-84b3-4b96-9871-de7615e1aa85&open=dac9dc42-84b3-4b96-9871-de7615e1aa85
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=72db672a-c871-4fcf-a103-05e65065c4df&open=72db672a-c871-4fcf-a103-05e65065c4df
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=562dfaf6-7c38-4b75-ba88-f3b2300135e2&open=562dfaf6-7c38-4b75-ba88-f3b2300135e2
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=3771c9be-b957-4150-9a6c-bc8f5410710c&open=3771c9be-b957-4150-9a6c-bc8f5410710c
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=f598e995-625d-4b6e-a78e-07317c5c8f5a&open=f598e995-625d-4b6e-a78e-07317c5c8f5a
GitHub links:
- https://github.com/openmrs/openmrs-core/blob/2.3.1/api/src/main/java/org/openmrs/ConceptSource.java#L55-L89
- https://github.com/openmrs/openmrs-core/blob/2.3.1/api/src/main/java/org/openmrs/ConceptSource.java#L119-L127
Problem:
Overwriting a parent class method only so that one command is a call to the parent class method. The author of this code forgot about inheritance?
Solution:
Removal of unnecessary calls and use of inheritance.