Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Core 2.4.0
    • Component/s: None
    • Labels:
    • Complexity:
      Low

      Description

      From https://wiki.openmrs.org/display/docs/Java+Conventions

      Imports that are not used should be removed, remember that you introduce dependencies that are not needed!

      First case:

      Second case:

      Third case:

      • SonarQube links:
      1. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDl&open=AXParDec5zdzQEOFIPDl
      2. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDr&open=AXParDec5zdzQEOFIPDr
      3. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDo&open=AXParDec5zdzQEOFIPDo
      4. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDq&open=AXParDec5zdzQEOFIPDq
      5. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDn&open=AXParDec5zdzQEOFIPDn
      6. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDm&open=AXParDec5zdzQEOFIPDm
      7. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDp&open=AXParDec5zdzQEOFIPDp
      • GitHub links:
      1. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L14
      2. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L20-L24
      3. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L27

      Fourth case:

      Fifth case:

      Sixth case:

      Seventh case:

      • SonarQube links:
      1. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJx5cGYr-AYGNaFq&open=AXK-qJx5cGYr-AYGNaFq
      2. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDuY5zdzQEOFIPFF&open=AXParDuY5zdzQEOFIPFF
      3. https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJx5cGYr-AYGNaFo&open=AXK-qJx5cGYr-AYGNaFo
      • GitHub links:
      1. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L27
      2. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L32
      3. https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L52

      Eighth case:

      Problem:
      Old and unused imports.

      Solution:
      Removing them.

        Gliffy Diagrams

          Attachments

            Activity

              People

              Assignee:
              insookwa Ivan Nsookwa
              Reporter:
              sacull Lukasz Debicki
              Designated Committer:
              Daniel Kayiwa Daniel Kayiwa
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: