Details
-
Sub-task
-
Status: Closed
-
Should
-
Resolution: Fixed
-
None
-
None
-
Low
Description
From https://wiki.openmrs.org/display/docs/Java+Conventions
Imports that are not used should be removed, remember that you introduce dependencies that are not needed!
First case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AWcHAZjg8fYkPidqGdVo&open=AWcHAZjg8fYkPidqGdVo
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/FormResource.java#L17
Second case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AWcHAZiJ8fYkPidqGdVn&open=AWcHAZiJ8fYkPidqGdVn
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/GlobalProperty.java#L18
Third case:
- SonarQube links:
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDl&open=AXParDec5zdzQEOFIPDl
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDr&open=AXParDec5zdzQEOFIPDr
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDo&open=AXParDec5zdzQEOFIPDo
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDq&open=AXParDec5zdzQEOFIPDq
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDn&open=AXParDec5zdzQEOFIPDn
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDm&open=AXParDec5zdzQEOFIPDm
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDec5zdzQEOFIPDp&open=AXParDec5zdzQEOFIPDp
- GitHub links:
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L14
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L20-L24
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Patient.java#L27
Fourth case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDzV5zdzQEOFIPFV&open=AXParDzV5zdzQEOFIPFV
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/db/hibernate/NativeIfNotAssignedIdentityGenerator.java#L17
Fifth case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParD045zdzQEOFIPFf&open=AXParD045zdzQEOFIPFf
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/db/hibernate/search/LuceneQuery.java#L37
Sixth case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJyecGYr-AYGNaFw&open=AXK-qJyecGYr-AYGNaFw
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/EncounterServiceImpl.java#L23
Seventh case:
- SonarQube links:
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJx5cGYr-AYGNaFq&open=AXK-qJx5cGYr-AYGNaFq
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParDuY5zdzQEOFIPFF&open=AXParDuY5zdzQEOFIPFF
- https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXK-qJx5cGYr-AYGNaFo&open=AXK-qJx5cGYr-AYGNaFo
- GitHub links:
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L27
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L32
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java#L52
Eighth case:
- SonarQube link: https://sonar.openmrs.org/project/issues?id=org.openmrs%3Aopenmrs&issues=AXParEKQ5zdzQEOFIPF6&open=AXParEKQ5zdzQEOFIPF6
- GitHub link: https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java#L26
Problem:
Old and unused imports.
Solution:
Removing them.