[LBAC-9] Failed to restrict the the patient by location when searched using the UUID. Created: 2018-07-09  Updated: 2018-07-12  Resolved: 2018-07-12

Status: Closed
Project: Location Based Access Control
Component/s: None
Affects Version/s: None
Fix Version/s: 0.1.0

Type: Bug Priority: Should
Reporter: Suthagar Kailayapathy Assignee: Suthagar Kailayapathy
Resolution: Fixed Votes: 0
Labels: gsoc2018
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Complexity: Low
Daniel Kayiwa, Suthagar Kailayapathy
Designated Committer: Suthagar Kailayapathy


Location based access control module only prepared to deal with getPatients() and getPatient() methods from PatientService. 

But there is another method called getPatientByUuid() which direct access to the DAO. So it should be restricted by the location property to ensure the functionality of the module.

Dev Notes

Need to add an AOP Advise for getPatientByUuid() method here : https://github.com/openmrs/openmrs-module-locationbasedaccess/blob/master/api/src/main/java/org/openmrs/module/locationbasedaccess/PatientSearchAdviser.java


Comment by Suthagar Kailayapathy [ 2018-07-10 ]

Added fix to this ticket. Please review and merge this PR : https://github.com/openmrs/openmrs-module-locationbasedaccess/pull/11


Comment by Daniel Kayiwa [ 2018-07-10 ]

Merged at https://github.com/openmrs/openmrs-module-locationbasedaccess/commit/d2b27610fcca9f52ad4a41135512fa16aa2f8e12
Thanks Suthagar Kailayapathy

Comment by Suthagar Kailayapathy [ 2018-07-12 ]

Can we close this ticket since it was fixed?

Generated at Tue Feb 19 16:11:35 UTC 2019 using Jira 7.13.1#713001-sha1:5e06076c2d215a6f699b7e5c90ab2fae7ba5a1ce.