[TRUNK-4418] Fix random failure of ModuleActivatorTest Created: 2014-07-08  Updated: 2015-09-22  Resolved: 2014-12-11

Status: Closed
Project: OpenMRS Core
Component/s: None
Affects Version/s: Platform 1.10.0, Platform 1.11.0, Platform 1.12.0
Fix Version/s: Platform 1.11.0, Platform 2.0.0

Type: Bug Priority: Should
Reporter: Daniel Kayiwa Assignee: Jakub Kondrat
Resolution: Fixed Votes: 0
Labels: soldevelo
Remaining Estimate: 0 minutes
Time Spent: 1 hour
Original Estimate: Not Specified

Complexity: Medium
Watchers:
Daniel Kayiwa, Jakub Kondrat, Kaweesi Joseph, Krzysztof Kaczmarczyk

 Description   

This unit test passes and fails randomly:
shouldStopDependantModulesOnStopModule(org.openmrs.module.ModuleActivatorTest)

We need to fix it such that it passes all the time.

After fixing this, remove the @Ignore in:
master at: https://github.com/openmrs/openmrs-core/commit/8155a771f2a5aed52078eca21ac2f8382f36ab08
1.11.x at: https://github.com/openmrs/openmrs-core/commit/1cd7d08e13fb67a210b4459a51e28ac887be757a
1.10.x at: https://github.com/openmrs/openmrs-core/commit/0aaf8e6e09b1302403aec877ef5f6ca0533220e7



 Comments   
Comment by Jakub Kondrat [ 2014-11-06 ]

The call order of willStop() was reversed

PR: https://github.com/openmrs/openmrs-core/pull/1136

Comment by Daniel Kayiwa [ 2014-11-27 ]

Merged at: https://github.com/openmrs/openmrs-core/commit/007c1a7777eddc48ef7e3e88c2532598753a1562
And back ported to 1.11.x at https://github.com/openmrs/openmrs-core/commit/85412bd03ccfb323616067a32138aedc3e2101f1
Thanks Jakub Kondrat

Comment by Kaweesi Joseph [ 2014-12-11 ]

Am closing this ticket as we are getting it into 1.11.0-beta, i still saw the @ignore at 1cd7d08e13fb67a210b4459a51e28ac887be757a We may address any issues later on when they arise

Generated at Sat Feb 16 18:09:01 UTC 2019 using Jira 7.13.1#713001-sha1:5e06076c2d215a6f699b7e5c90ab2fae7ba5a1ce.