[RESTWS-698] Implementing Program Enrollment Attributes Created: 2018-01-23  Updated: 2018-11-30

Status: Code Review (Post-Commit)
Project: Webservices REST Module
Component/s: None
Affects Version/s: None
Fix Version/s: 2.22.0

Type: New Feature Priority: Should
Reporter: Brian Njenga Assignee: Brian Njenga
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relation
relates to TRUNK-4755 Implementing Program Enrollment Attri... Closed
Complexity: Medium

 Description   

 

Program attributes were implemented in Bahmni at aeb460, The web services related changes need to be moved to the webservices.rest module.



 Comments   
Comment by Brian Njenga [ 2018-01-25 ]

Daniel Kayiwa I've integrated the changes into omod 1.8 is it the proper version to integrate into or should I move them?

Comment by Daniel Kayiwa [ 2018-01-25 ]

Brian Njenga since they require OpenMRS platform 2.2, then create a new 2.2 folder

Comment by Brian Njenga [ 2018-01-25 ]

Okay, Thanks.

Comment by Brian Njenga [ 2018-02-20 ]

Daniel Kayiwa Kindly review my PR: https://github.com/openmrs/openmrs-module-webservices.rest/pull/323

Comment by Daniel Kayiwa [ 2018-02-20 ]

Brian Njenga i have just put another comment for you on github

Comment by Daniel Kayiwa [ 2018-02-20 ]

Brian Njenga whenever you are done addressing review comments, remember to always update the ticket status.

Comment by Brian Njenga [ 2018-02-20 ]

Daniel Kayiwa Kindly review my PR: https://github.com/openmrs/openmrs-module-webservices.rest/pull/323

Comment by Daniel Kayiwa [ 2018-02-20 ]

Merged at https://github.com/openmrs/openmrs-module-webservices.rest/commit/6fcc43c571d76e12b124995783052d30327a887c
Let us see what happens with bamboo

Comment by Brian Njenga [ 2018-02-20 ]

 

Cool, No problem.

Comment by Daniel Kayiwa [ 2018-02-20 ]

Brian Njenga did you see this? https://ci.openmrs.org/browse/RESTWS-RESTWS/latest

Comment by Brian Njenga [ 2018-02-20 ]

Just had a look, I don't understand what's going wrong. should I clone the repo and set up a fresh?

Comment by Daniel Kayiwa [ 2018-02-20 ]

That is what i was about to tell you.

Comment by Brian Njenga [ 2018-02-20 ]

Cool, I'll also upgrade my JDK version to match the one in the CI runtime

Comment by Daniel Kayiwa [ 2018-02-20 ]

Brian Njenga for now, you do not have to do this because all your changes are merged.

Comment by Brian Njenga [ 2018-02-20 ]

Cool, Thanks.

Comment by Mark Goodrich [ 2018-11-30 ]

Daniel Kayiwa I believe this can be closed?

Generated at Thu Dec 13 10:26:11 UTC 2018 using JIRA 7.5.1#75006-sha1:7df2574a6cc842da727f00de4c5ce9ac07701368.